hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Enis Soztutar (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-13030) [1.0.0 polish] Make ScanMetrics public again and align Put 'add' with Get, Delete, etc., addColumn
Date Fri, 13 Feb 2015 00:14:11 GMT

     [ https://issues.apache.org/jira/browse/HBASE-13030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Enis Soztutar updated HBASE-13030:
    Attachment: hbase-13030-scanmetrics.patch

I think the major confusion on both of our ends was the PB version of ScanMetrics vs the POJO

I was looking at when we are using the PB version, and it seems that we are serializing the
metrics to the scan object using PB, but the actual scanners keep the POJO based one. 

It says in some comment that the ScanMetrics is serialized for TableInputFormat subclasses,
but I was not able to find any reference that uses this. Only updateCounters uses it, but
I think in this context, the scanner is already there. We are still serializing the ScanMetrics
to the Scan still in case, but no code patch now reads it back. 

Anyway attaching a dfraft patch of what I had in mind. It is a combination of your v1 and
v3 patches for the scan side. Totally not tested. It may not be covering all the cases as
well (not sure in what cases we need to carry the metrics serialized back in Scan and send
back in MR) 

> [1.0.0 polish] Make ScanMetrics public again and align Put 'add' with Get, Delete, etc.,
> --------------------------------------------------------------------------------------------------
>                 Key: HBASE-13030
>                 URL: https://issues.apache.org/jira/browse/HBASE-13030
>             Project: HBase
>          Issue Type: Bug
>          Components: Operability
>    Affects Versions: 1.0.0
>            Reporter: stack
>            Assignee: stack
>             Fix For: 1.0.0, 2.0.0, 1.1.0
>         Attachments: 13030.txt, 13030v2.txt, 13030v3.txt, hbase-13030-scanmetrics.patch
> These are some of the items raised by [~larsgeorge] looking at our API for first time
in a long time trying to update examples in the HBase Book.
> 1. ScanMetrics used to be available with some gymnastics in old days. Now it is IA.private
and to get at it from Scan context, you need to use private ProtobufUtils. This seems like
useful advanced user utility that should not be shut down.
> 2. Put is not like the others around the addColumn usage. Fix.
> [~enis] Hopefully these ok to go in (the Scan class addition is a little ugly but didn't
want to do anything more adventurous this late in the game).

This message was sent by Atlassian JIRA

View raw message