hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13004) Make possible to explain why HBaseTestingUtility.waitFor fails
Date Tue, 10 Feb 2015 16:02:11 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14314378#comment-14314378
] 

Hadoop QA commented on HBASE-13004:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12697802/HBASE-13004-branch-1.patch
  against branch-1 branch at commit a3f495f20d492ab491f2af4759b2aef5d5c3bd74.
  ATTACHMENT ID: 12697802

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 12 new or modified
tests.

    {color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12759//console

This message is automatically generated.

> Make possible to explain why HBaseTestingUtility.waitFor fails
> --------------------------------------------------------------
>
>                 Key: HBASE-13004
>                 URL: https://issues.apache.org/jira/browse/HBASE-13004
>             Project: HBase
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 1.0.0, 2.0.0
>            Reporter: Andrey Stepachev
>            Assignee: Andrey Stepachev
>            Priority: Minor
>         Attachments: HBASE-13004-branch-1.patch, HBASE-13004.patch, HBASE-13004.patch
>
>
> HBaseTestingUtility has good methods for waiting conditions, but with one drawback, when
waitfor fails, there is no way to explain what happened (fail() called from internals and
that is not very easy to intercept and explain state of failure).
> That would be great to have enhanced Predicate which can explain state after it failed
to wait for.
> That can looks like
> {code}
> HBaseTestingUtility.waitFor(10000, new ExplainingPredicate() {
>    boolean evaluate() {
>      ... some evaluation code
>    }
>    String explain() {
>     ... generate brief explanation of what to be expected, but not happened
>    }
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message