hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Lawlor (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12924) HRegionServer#MovedRegionsCleaner Chore does not start
Date Fri, 27 Feb 2015 17:52:04 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14340445#comment-14340445
] 

Jonathan Lawlor commented on HBASE-12924:
-----------------------------------------

Looks like it ran into the flaky test TestAcidGuarantees, looks unrelated. We can retry the
QA build to be sure. 

The checkstyle error is coming from an unused import in HRegionServer.java (there also seem
to be some ununsed imports inside TestMovedRegionsCleaner that could be removed). The checkstyle
also recommends we declare MovedRegionsCleaner as a final class.

> HRegionServer#MovedRegionsCleaner Chore does not start
> ------------------------------------------------------
>
>                 Key: HBASE-12924
>                 URL: https://issues.apache.org/jira/browse/HBASE-12924
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jonathan Lawlor
>            Assignee: Sameet Agarwal
>            Priority: Minor
>             Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.11
>
>         Attachments: first-task-v2.patch, first-task-v3.patch, first-task.patch
>
>
> This issue is very similar to the one described in HBASE-11354. The method createAndStart
in MovedRegionsCleaner creates an instance of the chore but never starts the underlying thread:
> {code}
>     static MovedRegionsCleaner createAndStart(HRegionServer rs){
>       Stoppable stoppable = new Stoppable() {
>         private volatile boolean isStopped = false;
>         @Override public void stop(String why) { isStopped = true;}
>         @Override public boolean isStopped() {return isStopped;}
>       };
>       return new MovedRegionsCleaner(rs, stoppable);
>     }
> {code}
> Nobody has noticed this issue so far so the Chore may not be that important



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message