hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ravi Kishore Valeti (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12102) Duplicate keys in HBase.RegionServer metrics JSON
Date Tue, 10 Feb 2015 04:51:35 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14313562#comment-14313562
] 

Ravi Kishore Valeti commented on HBASE-12102:
---------------------------------------------

Hi [~andrew.purtell@gmail.com] - My Patch was on top of 0.98 branch Code line.

I do not see any implementations in hadoop-compat module. It has only the interfaces. Also,
I did a search for context on the entire project and I could only find these 4 occurrences
which I fixed. 

So, I believe we do not need to make any changes in hadoop-compat module.

> Duplicate keys in HBase.RegionServer metrics JSON
> -------------------------------------------------
>
>                 Key: HBASE-12102
>                 URL: https://issues.apache.org/jira/browse/HBASE-12102
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 1.0.0, 2.0.0, 0.98.10
>            Reporter: Andrew Purtell
>            Assignee: Ravi Kishore Valeti
>            Priority: Minor
>             Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.11
>
>         Attachments: HBASE-12102.patch
>
>
> The JSON returned by /jmx on the RegionServer contains duplicate 'tag.Context' keys for
various HBase.RegionServer metrics. 
> Regions:
> {noformat}
> {
>     "name" : "Hadoop:service=HBase,name=RegionServer,sub=Regions",
>     "modelerType" : "RegionServer,sub=Regions",
>     "tag.Context" : "regionserver",
>     "tag.Context" : "regionserver",
>     "tag.Hostname" : "some.host.name",
>     ...
> }
> {noformat}
> Server:
> {noformat}
> "name" : "Hadoop:service=HBase,name=RegionServer,sub=Server",
>     "modelerType" : "RegionServer,sub=Server",
>     "tag.Context" : "regionserver",
>     "tag.zookeeperQuorum" : "some.zookeeper.quorum.peers",
>     "tag.serverName" : "some.server.name",
>     "tag.clusterId" : "88c186ea-2308-4713-8b5f-5a3e829cbb10",
>     "tag.Context" : "regionserver",
>     ...
> }
> {noformat}
> IPC:
> {noformat}
> {
>     "name" : "Hadoop:service=HBase,name=IPC,sub=IPC",
>     "modelerType" : "IPC,sub=IPC",
>     "tag.Context" : "ipc",
>     "tag.Context" : "ipc",
>     "tag.Hostname" : "some.host.name",
>     ...
> }
> {noformat}
> This can cause issues with some JSON parsers. We should avoid emitting duplicate keys
if it is under our control.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message