hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Purtell (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-8329) Limit compaction speed
Date Thu, 05 Feb 2015 02:52:36 GMT

    [ https://issues.apache.org/jira/browse/HBASE-8329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14306542#comment-14306542
] 

Andrew Purtell commented on HBASE-8329:
---------------------------------------

I don't see a compatibility problem with the 0.98 patch. The affected existing interfaces
are

{panel:title=CompactionContext}
Annotated Private
Removes List<Path> compact ( )
Adds List<Path> compact ( CompactionContext, CompactionThroughputController)
{panel}

{panel:title=Compactor}
Annotated Private
Removes boolean performCompaction ( InternalScanner, CellSink, long )
Adds boolean performCompaction ( InternalScanner, CellSink, long, CompactionThroughputController
)
{panel}

{panel:title=HRegion}
Annotated Private
Removes boolean compact ( CompactionContext, Store )
Adds boolean compact ( CompactionContext, Store, CompactionThroughputController)
Adds double getCompactionPressure ( )
{panel}

{panel:title=HRegionServer}
Annotated Private
Adds double getCompactionPressure ( )
{panel}

{panel:title=HStore}
Annotated Private
Removes List<StoreFile> compact ( CompactionContext )
Adds List<StoreFile> compact ( CompactionContext, CompactionThroughputController)
Adds double getCompactionPressure ( )
{panel}

{panel:title=Store}
Annotated Private
Removes List<StoreFile> compact ( CompactionContext )
Adds List<StoreFile> compact ( CompactionContext, CompactionThroughputController)
Adds double getCompactionPressure ( )
{panel}

{panel:title=StoreFileManager}
Annotated Private
Adds double StoreFileManager.getCompactionPressure ( )
{panel}

They are all annotated private. If we really want to be sure, we can add back:
- Store#compact ( CompactionContext )
- CompactionContext#compact ( )


> Limit compaction speed
> ----------------------
>
>                 Key: HBASE-8329
>                 URL: https://issues.apache.org/jira/browse/HBASE-8329
>             Project: HBase
>          Issue Type: Improvement
>          Components: Compaction
>            Reporter: binlijin
>            Assignee: zhangduo
>             Fix For: 2.0.0, 1.1.0
>
>         Attachments: HBASE-8329-0.98.patch, HBASE-8329-10.patch, HBASE-8329-11.patch,
HBASE-8329-12.patch, HBASE-8329-2-trunk.patch, HBASE-8329-3-trunk.patch, HBASE-8329-4-trunk.patch,
HBASE-8329-5-trunk.patch, HBASE-8329-6-trunk.patch, HBASE-8329-7-trunk.patch, HBASE-8329-8-trunk.patch,
HBASE-8329-9-trunk.patch, HBASE-8329-branch-1.patch, HBASE-8329-trunk.patch, HBASE-8329_13.patch,
HBASE-8329_14.patch, HBASE-8329_15.patch, HBASE-8329_16.patch, HBASE-8329_17.patch
>
>
> There is no speed or resource limit for compaction´╝îI think we should add this feature
especially when request burst.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message