Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A33481041C for ; Thu, 22 Jan 2015 19:04:38 +0000 (UTC) Received: (qmail 67533 invoked by uid 500); 22 Jan 2015 19:04:38 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 67484 invoked by uid 500); 22 Jan 2015 19:04:38 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 67470 invoked by uid 99); 22 Jan 2015 19:04:38 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 Jan 2015 19:04:38 +0000 Date: Thu, 22 Jan 2015 19:04:38 +0000 (UTC) From: "Hadoop QA (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-12904) Threading issues in region_mover.rb MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-12904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14287992#comment-14287992 ] Hadoop QA commented on HBASE-12904: ----------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12693927/HBASE-12904.patch against master branch at commit 319f9bb7918af8cfe7e65f97b654f37f0d5983f3. ATTACHMENT ID: 12693927 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 checkstyle{color}. The applied patch does not increase the total number of checkstyle errors {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:green}+1 site{color}. The mvn site goal succeeds with this patch. {color:green}+1 core tests{color}. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/12549//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12549//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12549//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12549//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12549//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12549//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12549//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12549//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12549//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12549//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12549//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12549//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/12549//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12549//console This message is automatically generated. > Threading issues in region_mover.rb > ----------------------------------- > > Key: HBASE-12904 > URL: https://issues.apache.org/jira/browse/HBASE-12904 > Project: HBase > Issue Type: Bug > Affects Versions: 0.98.9 > Reporter: Lars Hofhansl > Assignee: Andrew Purtell > Fix For: 1.0.0, 2.0.0, 0.98.10, 1.1.0 > > Attachments: HBASE-12904-0.98.patch, HBASE-12904.patch > > > We've seen various race conditions when using region_mover with multiple threads. > {code} > NoMethodError: undefined method `getScanner' for nil:NilClass > isSuccessfulScan at /home/sfdc/current//bigdata-hbase/hbase/hbase/bin/region_mover.rb:138 > unloadRegions at /home/sfdc/current//bigdata-hbase/hbase/hbase/bin/region_mover.rb:360 > {code} > {code} > NoMethodError: undefined method `[]=' for nil:NilClass > getTable at /home/sfdc/current//bigdata-hbase/hbase/hbase/bin/region_mover.rb:64 > unloadRegions at /home/sfdc/current//bigdata-hbase/hbase/hbase/bin/region_mover.rb:359 > {code} > Looking at getTable, it's not thread safe. So the multithreaded that was added is incorrect. -- This message was sent by Atlassian JIRA (v6.3.4#6332)