Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Thu, 29 Jan 2015 00:11:36 +0000 (UTC)
From: "Kevin Risden (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12767774.1421339877000.200040.1422490296272@Atlassian.JIRA>
In-Reply-To: <JIRA.12767774.1421339877000@Atlassian.JIRA>
References: <JIRA.12767774.1421339877000@Atlassian.JIRA>
 <JIRA.12767774.1421339877510@arcas>
Subject: [jira] [Commented] (HBASE-12867) Shell does not support custom
 replication endpoint specification
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-12867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14296114#comment-14296114 ] 

Kevin Risden commented on HBASE-12867:
--------------------------------------

I'll create a follow up JIRA for adding listPeerConfigs and getPeerConfig to the HBase shell.

{quote}
In the patch why did you have a test that is commented out?
{code}+    # assert_raise fails on native exceptions - https://jira.codehaus.org/browse/JRUBY-5279{code}
{quote}

I wanted to test that when adding a peer with the same id that an exception is thrown up to the shell. The exception is actually a java.lang.IllegalArgumentException but I can't catch it with assert_raise. JRUBY-5279 identifies the issue and it looks like it is fixed in JRuby 1.7 but HBase is using JRuby 1.6.8. I can remove the test if that helps.

{quote}
One last thing is that, regular commands like create table, etc define constants used in hbase-shell/src/main/ruby/hbase.rb. so that the user does not have to do :CONSTANT, and instead can do CONSTANT. We can do the same thing for consistency with the other commands.
{quote}

Ah that makes sense. I was trying to find how the other commands didn't need to use colons. I'll make this change.

> Shell does not support custom replication endpoint specification
> ----------------------------------------------------------------
>
>                 Key: HBASE-12867
>                 URL: https://issues.apache.org/jira/browse/HBASE-12867
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Andrew Purtell
>            Assignee: Kevin Risden
>              Labels: beginner, beginners
>             Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.11
>
>         Attachments: HBASE-12867-v1.patch, HBASE-12867-v2.patch, HBASE-12867.patch
>
>
> On HBASE-12254 and also at https://github.com/risdenk/hbase-custom-replication-endpoint-example [~risdenk] made the following observations and suggestions regarding custom replication endpoints that I think are a reasonable blueprint for improvement:
> {quote}
> I was trying out the pluggable replication endpoint feature and found the following:
> - you must use the ReplicationAdmin to add the new ReplicationEndpoint
> - hbase shell add_peer command doesn't support specifying a custom class
> - hbase shell add_peer relies on the newly deprecated ReplicationAdmin addPeer methods
> - ReplicationAdmin addPeer tableCfs is now a Map<TableName, ? extends Collection<String>> instead of a string
> {quote}
> We should fix the add_peer command in the shell at least.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)