Return-Path: 
 <issues-return-180347-apmail-hbase-issues-archive=hbase.apache.org@hbase.apache.org>
X-Original-To: apmail-hbase-issues-archive@www.apache.org
Delivered-To: apmail-hbase-issues-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 2C1341006B
	for <apmail-hbase-issues-archive@www.apache.org>;
 Tue, 27 Jan 2015 17:30:35 +0000 (UTC)
Received: (qmail 1787 invoked by uid 500); 27 Jan 2015 17:30:35 -0000
Delivered-To: apmail-hbase-issues-archive@hbase.apache.org
Received: (qmail 1737 invoked by uid 500); 27 Jan 2015 17:30:35 -0000
Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@hbase.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@hbase.apache.org>
List-Post: <mailto:issues@hbase.apache.org>
List-Id: <issues.hbase.apache.org>
Delivered-To: mailing list issues@hbase.apache.org
Received: (qmail 1724 invoked by uid 99); 27 Jan 2015 17:30:35 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Jan 2015 17:30:35 +0000
Date: Tue, 27 Jan 2015 17:30:35 +0000 (UTC)
From: "Kevin Risden (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12767774.1421339877000.185701.1422379835063@Atlassian.JIRA>
In-Reply-To: <JIRA.12767774.1421339877000@Atlassian.JIRA>
References: <JIRA.12767774.1421339877000@Atlassian.JIRA>
 <JIRA.12767774.1421339877510@arcas>
Subject: [jira] [Commented] (HBASE-12867) Shell does not support custom
 replication endpoint specification
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/HBASE-12867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14293841#comment-14293841 ] 

Kevin Risden commented on HBASE-12867:
--------------------------------------

Added HBASE-12867-v1.patch which addresses the comments by [~enis].

The backwards compatibility is still there and makes use of some rubyism for it to work. The documentation for the command was updated with the only real change from the comments above being that arguments must be preceded by a colon (ie: :ENDPOINT_CLASSNAME or :TABLE_CFS).

There probably should be tests for this but didn't see tests for the other shell commands. I can look into that later this week.

> Shell does not support custom replication endpoint specification
> ----------------------------------------------------------------
>
>                 Key: HBASE-12867
>                 URL: https://issues.apache.org/jira/browse/HBASE-12867
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Andrew Purtell
>            Assignee: Kevin Risden
>              Labels: beginner, beginners
>             Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.11
>
>         Attachments: HBASE-12867-v1.patch, HBASE-12867.patch
>
>
> On HBASE-12254 and also at https://github.com/risdenk/hbase-custom-replication-endpoint-example [~risdenk] made the following observations and suggestions regarding custom replication endpoints that I think are a reasonable blueprint for improvement:
> {quote}
> I was trying out the pluggable replication endpoint feature and found the following:
> - you must use the ReplicationAdmin to add the new ReplicationEndpoint
> - hbase shell add_peer command doesn't support specifying a custom class
> - hbase shell add_peer relies on the newly deprecated ReplicationAdmin addPeer methods
> - ReplicationAdmin addPeer tableCfs is now a Map<TableName, ? extends Collection<String>> instead of a string
> {quote}
> We should fix the add_peer command in the shell at least.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)