Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Wed, 14 Jan 2015 22:55:35 +0000 (UTC)
From: "Sean Busbey (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12766472.1420825416000.86253.1421276135080@Atlassian.JIRA>
In-Reply-To: <JIRA.12766472.1420825416000@Atlassian.JIRA>
References: <JIRA.12766472.1420825416000@Atlassian.JIRA>
 <JIRA.12766472.1420825416173@arcas>
Subject: [jira] [Commented] (HBASE-12831) Changing the set of vis labels a
 user has access to doesn't generate an audit log event
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-12831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14277841#comment-14277841 ] 

Sean Busbey commented on HBASE-12831:
-------------------------------------

{code}
+      } catch (IOException e) {
+        LOG.warn("Failed to get active system user.");
+      }
{code}

Please include the exception object. I'd prefer if the exception object was in a second debug message, e.g.

{code}
+      } catch (IOException e) {
+        LOG.warn("Failed to get active system user.");
+        LOG.debug("details on failure to get active system user.", e);
+      }
{code}

Some way of logging the exception for the active user failure aside, overall looks good. +1.

> Changing the set of vis labels a user has access to doesn't generate an audit log event
> ---------------------------------------------------------------------------------------
>
>                 Key: HBASE-12831
>                 URL: https://issues.apache.org/jira/browse/HBASE-12831
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 1.0.0, 2.0.0, 0.98.6
>            Reporter: Sean Busbey
>            Assignee: Ashish Singhi
>              Labels: audit
>             Fix For: 1.0.1, 0.98.11
>
>         Attachments: HBASE-12831-v2.patch, HBASE-12831-v3.patch, HBASE-12831.patch, HBASE-12831v4.patch
>
>
> Right now, the AccessController makes sure that (when users care about audit events) we generate an audit log event for any access change, like granting or removing a permission from a user.
> When the set of labels a user has access to is altered, it gets handled by the VisibilityLabelService and we don't log anything to the audit log.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)