Return-Path: 
 <issues-return-178418-apmail-hbase-issues-archive=hbase.apache.org@hbase.apache.org>
X-Original-To: apmail-hbase-issues-archive@www.apache.org
Delivered-To: apmail-hbase-issues-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id D1D6217278
	for <apmail-hbase-issues-archive@www.apache.org>;
 Tue, 13 Jan 2015 03:44:33 +0000 (UTC)
Received: (qmail 85135 invoked by uid 500); 13 Jan 2015 03:44:35 -0000
Delivered-To: apmail-hbase-issues-archive@hbase.apache.org
Received: (qmail 85044 invoked by uid 500); 13 Jan 2015 03:44:35 -0000
Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@hbase.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@hbase.apache.org>
List-Post: <mailto:issues@hbase.apache.org>
List-Id: <issues.hbase.apache.org>
Delivered-To: mailing list issues@hbase.apache.org
Received: (qmail 85027 invoked by uid 99); 13 Jan 2015 03:44:35 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 Jan 2015 03:44:35 +0000
Date: Tue, 13 Jan 2015 03:44:35 +0000 (UTC)
From: "Anoop Sam John (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12766472.1420825416000.67085.1421120675144@Atlassian.JIRA>
In-Reply-To: <JIRA.12766472.1420825416000@Atlassian.JIRA>
References: <JIRA.12766472.1420825416000@Atlassian.JIRA>
 <JIRA.12766472.1420825416173@arcas>
Subject: [jira] [Commented] (HBASE-12831) Changing the set of vis labels a
 user has access to doesn't generate an audit log event
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/HBASE-12831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14274654#comment-14274654 ] 

Anoop Sam John commented on HBASE-12831:
----------------------------------------

{code}
List<String> labelsStr = new ArrayList<String>(visLabels.size());
...
labelsStr.add(Bytes.toString(label));
...
if (AUDITLOG.isTraceEnabled()) {
  AUDITLOG.trace("Add labels: " + labelsStr);
}
{code}
Have labels in a List<byte[]> Do the string conversion only within if block..   Similarly other places too.
{code}
if (AUDITLOG.isTraceEnabled()) {
  // make labelsStr List convertion bytes to string
  AUDITLOG.trace("Add labels: " + labelsStr);
}
{code}

> Changing the set of vis labels a user has access to doesn't generate an audit log event
> ---------------------------------------------------------------------------------------
>
>                 Key: HBASE-12831
>                 URL: https://issues.apache.org/jira/browse/HBASE-12831
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 1.0.0, 2.0.0, 0.98.6
>            Reporter: Sean Busbey
>            Assignee: Ashish Singhi
>              Labels: audit
>             Fix For: 1.0.1, 0.98.11
>
>         Attachments: HBASE-12831.patch
>
>
> Right now, the AccessController makes sure that (when users care about audit events) we generate an audit log event for any access change, like granting or removing a permission from a user.
> When the set of labels a user has access to is altered, it gets handled by the VisibilityLabelService and we don't log anything to the audit log.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)