Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E6840175AF for ; Wed, 14 Jan 2015 18:27:33 +0000 (UTC) Received: (qmail 70004 invoked by uid 500); 14 Jan 2015 18:27:35 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 69956 invoked by uid 500); 14 Jan 2015 18:27:35 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 69939 invoked by uid 99); 14 Jan 2015 18:27:35 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 14 Jan 2015 18:27:35 +0000 Date: Wed, 14 Jan 2015 18:27:35 +0000 (UTC) From: "Andrew Purtell (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-12644) Visibility Labels: issue with storing super users in labels table MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-12644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14277386#comment-14277386 ] Andrew Purtell commented on HBASE-12644: ---------------------------------------- I assume you want the 0.98 patch applied. This feature is experimental in 0.98 so the considerations explained in the release notes are sufficient. Applying now. > Visibility Labels: issue with storing super users in labels table > ----------------------------------------------------------------- > > Key: HBASE-12644 > URL: https://issues.apache.org/jira/browse/HBASE-12644 > Project: HBase > Issue Type: Bug > Components: security > Affects Versions: 0.98.8, 0.99.2 > Reporter: Jerry He > Assignee: Jerry He > Fix For: 1.0.0, 2.0.0 > > Attachments: 12644-0.98.patch, HBASE-12644-master-v2.patch, HBASE-12644-master-v3.patch, HBASE-12644-master.patch > > > Super users have all the permissions for ACL and Visibility labels. > They are defined in hbase-site.xml. > Currently in VisibilityController, we persist super user with their system permission in hbase:labels. > This makes change in super user difficult. > There are two issues: > In the current DefaultVisibilityLabelServiceImpl.addSystemLabel, we only add super user when we initially create the 'system' label. > No additional update after that even if super user changed. See code for details. > > Additionally, there is no mechanism to remove any super user from the labels table. > > We probably should not persist super users in the labels table. > They are in hbase-site.xml and can just stay in labelsCache and used from labelsCache after retrieval by Visibility Controller. -- This message was sent by Atlassian JIRA (v6.3.4#6332)