Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id F0A79104A1 for ; Tue, 20 Jan 2015 12:41:34 +0000 (UTC) Received: (qmail 32347 invoked by uid 500); 20 Jan 2015 12:41:34 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 32302 invoked by uid 500); 20 Jan 2015 12:41:34 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 32290 invoked by uid 99); 20 Jan 2015 12:41:34 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 20 Jan 2015 12:41:34 +0000 Date: Tue, 20 Jan 2015 12:41:34 +0000 (UTC) From: "Hadoop QA (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-11677) Make Logger instance modifiers consistent MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-11677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14283779#comment-14283779 ] Hadoop QA commented on HBASE-11677: ----------------------------------- {color:green}+1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12693277/HBASE-11677-v4.patch against master branch at commit f71b980d3715c94478930b614e63250ebb678899. ATTACHMENT ID: 12693277 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 545 new or modified tests. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 checkstyle{color}. The applied patch does not increase the total number of checkstyle errors {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:green}+1 site{color}. The mvn site goal succeeds with this patch. {color:green}+1 core tests{color}. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/12517//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12517//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12517//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12517//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12517//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12517//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12517//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12517//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12517//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12517//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12517//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12517//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/12517//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12517//console This message is automatically generated. > Make Logger instance modifiers consistent > ----------------------------------------- > > Key: HBASE-11677 > URL: https://issues.apache.org/jira/browse/HBASE-11677 > Project: HBase > Issue Type: Task > Reporter: Sean Busbey > Priority: Minor > Labels: beginner, sonar > Attachments: HBASE-11677-v1.patch, HBASE-11677-v2.patch, HBASE-11677-v3.patch, HBASE-11677-v4.patch, HBASE-11677.patch > > > We have some instances of Logger that are missing one of being private, static, and final. > ex from HealthChecker.java, missing final > {code} > private static Log LOG = LogFactory.getLog(HealthChecker.class); > {code} > * Clean up where possible by making {{private static final}} > * If we can't, add a non-javadoc note about why > One way to look for problematic instances is to grep for initial assignment for the commonly used LOG member, e.g. > * missing final: {{grep -r "LOG =" * | grep -v "final"}} > * missing static: {{grep -r "LOG =" * | grep -v "static"}} > * missing private: {{grep -r "LOG =" * | grep -v "private"}} -- This message was sent by Atlassian JIRA (v6.3.4#6332)