Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BA0D010784 for ; Tue, 6 Jan 2015 16:20:35 +0000 (UTC) Received: (qmail 27113 invoked by uid 500); 6 Jan 2015 16:20:36 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 27022 invoked by uid 500); 6 Jan 2015 16:20:36 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 26831 invoked by uid 99); 6 Jan 2015 16:20:36 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Jan 2015 16:20:36 +0000 Date: Tue, 6 Jan 2015 16:20:36 +0000 (UTC) From: "Cosmin Lehene (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-5205) Delete handles deleteFamily incorrectly MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-5205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14266335#comment-14266335 ] Cosmin Lehene commented on HBASE-5205: -------------------------------------- [~lhofhansl] did this fall through the cracks because it didn't have a fixVersion? > Delete handles deleteFamily incorrectly > --------------------------------------- > > Key: HBASE-5205 > URL: https://issues.apache.org/jira/browse/HBASE-5205 > Project: HBase > Issue Type: Bug > Components: Client > Reporter: Lars Hofhansl > Priority: Minor > Attachments: 5205.txt > > > Delete.deleteFamily clears all other markers for the same family. > That is not correct as some of these other markers might be for a later time. > That logic should be removed. > If (really) needed this can be slightly optimized by keeping track of the max TS so far for each family. > If both the TS-so-far and the TS of a new deleteFamily request is < LATEST_TIMESTAMP and the TS-so-far is < deleteFamily marker, or if both the TS-so-far and the new TS equal LATEST_TIMESTAMP, then the previous delete markerz for that family could be removed. > I think that might be overkill, as most deletes issued from clients are for LATEST_TIMESTAMP (which the server translates to the current time). > I'll have a (one-line) patch soon. Unless folks insist on the optimization I mentioned above. -- This message was sent by Atlassian JIRA (v6.3.4#6332)