hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12948) Increment#addColumn on the same column multi times produce wrong result
Date Fri, 30 Jan 2015 15:02:34 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14298711#comment-14298711
] 

Hadoop QA commented on HBASE-12948:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12695533/HBASE-12948-v0.patch
  against master branch at commit b08802a3e8e522f84519415b83455870b49bf8da.
  ATTACHMENT ID: 12695533

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12648//console

This message is automatically generated.

> Increment#addColumn on the same column multi times produce wrong result 
> ------------------------------------------------------------------------
>
>                 Key: HBASE-12948
>                 URL: https://issues.apache.org/jira/browse/HBASE-12948
>             Project: HBase
>          Issue Type: Bug
>          Components: Client, regionserver
>            Reporter: hongyu bi
>            Priority: Critical
>         Attachments: HBASE-12948-v0.patch, HBASE-12948.patch
>
>
> Case:
> Initially get('row1'):
> rowkey=row1 value=1
> run:
> Increment increment = new Increment(Bytes.toBytes("row1"));
> for (int i = 0; i < N; i++) {
>         increment.addColumn(Bytes.toBytes("cf"), Bytes.toBytes("c"), 1)
> }
> hobi.increment(increment);
> get('row1'):
> if N=1 then result is 2 else if N>1 the result will always be 1
> Cause:
> https://issues.apache.org/jira/browse/HBASE-7114 let increment extent mutation which
change familyMap from NavigableMap to List, so from client side, we can buffer many edits
on the same column;
> However, HRegion#increment use idx to iterate the get's results, here results.size<family.value().size
if N>1,so the latter edits on the same column won't match the condition {idx < results.size()
&& CellUtil.matchingQualifier(results.get(idx), kv) }, meantime the edits share the
same mvccVersion ,so this case happen.
> Fix:
> according to the put/delete#add on the same column behaviour ,
> fix from server side: process "last edit wins on the same column" inside HRegion#increment
to maintenance  HBASE-7114's extension and keep the same result from 0.94.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message