hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Purtell (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12936) Quota support for namespace should take region merge into account
Date Wed, 28 Jan 2015 18:10:36 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14295532#comment-14295532
] 

Andrew Purtell commented on HBASE-12936:
----------------------------------------

Skimmed the patch. 

Quick question:
{code}
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
index 5bc1f2d..5e6c21e 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
@@ -2802,7 +2802,12 @@ public class AssignmentManager {
         errorMsg = onRegionMergePONR(current, hri, serverName, transition);
         break;
       case MERGED:
-        errorMsg = onRegionMerged(current, hri, serverName, transition);
+        try {
+          regionStateListener.onRegionMerged(hri);
+          errorMsg = onRegionMerged(current, hri, serverName, transition);
+        } catch (IOException exp) {
+          errorMsg = StringUtils.stringifyException(exp);
+        }
         break;
       case MERGE_REVERTED:
         errorMsg = onRegionMergeReverted(current, hri, serverName, transition);
{code}

Here you are calling the listener's {{onRegionMerged}} callback but it looks like the next
statement can fail. Should the listener callback be moved to after the AM's {{onRegionMerged}}
returns? 

> Quota support for namespace should take region merge into account
> -----------------------------------------------------------------
>
>                 Key: HBASE-12936
>                 URL: https://issues.apache.org/jira/browse/HBASE-12936
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>         Attachments: 12936-002.txt
>
>
> HBASE-8410 added basic quota support for namespaces.
> However, region merge operation was not taken into account. This means, once region count
limit is reached, user table cannot be split even after some regions are successfully merged.
> This issue fixes the bug by adding hook in RegionStateListener for region merged event.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message