hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12925) Use acl cache for doing access control checks in prepare and clean phases of Bulkloading.
Date Tue, 27 Jan 2015 19:08:35 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14293992#comment-14293992
] 

Hudson commented on HBASE-12925:
--------------------------------

SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #780 (See [https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/780/])
HBASE-12925 Use acl cache for doing access control checks in prepare and clean phases of Bulkloading
(Srikanth Srungarapu) (matteo.bertozzi: rev 9115f303c19f01264272b4472108ff3e4b44907f)
* hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/TableAuthManager.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController.java


> Use acl cache for doing access control checks in prepare and clean phases of Bulkloading.
> -----------------------------------------------------------------------------------------
>
>                 Key: HBASE-12925
>                 URL: https://issues.apache.org/jira/browse/HBASE-12925
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Srikanth Srungarapu
>            Assignee: Srikanth Srungarapu
>             Fix For: 1.0.0, 2.0.0, 0.98.11
>
>         Attachments: HBASE-12925.patch, HBASE-12925_v2.patch
>
>
> Currently, prepareBulkLoad and cleanupBulkLoad are using "hasSomeAccess", which performs
scan on ACL table, instead of using TableAuthManager. Also, the method "hasSomeAccess" has
a logical error, as it doesn't filter the acl scan results by the current active user. More
specifically 
> {code}
> for (UserPermission userPerm: perms) {
>         for (Action userAction: userPerm.getActions()) {
>           if (userAction.equals(action)) {
>             return AuthResult.allow(method, "Access allowed", requestUser,
>               action, tableName, null, null);
>           }
>         }
>       }
> {code} 
> The if clause ideally should be having something like userPerm.getUser.equals(requestUser).
This issue will help us in getting rid of this problematic implementation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message