hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12925) Use acl cache for doing access control checks in prepare and clean phases of Bulkloading.
Date Tue, 27 Jan 2015 03:25:34 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14292921#comment-14292921
] 

Hadoop QA commented on HBASE-12925:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12694673/HBASE-12925_v2.patch
  against master branch at commit 1b9367d465dc99559b4ac36b30be5e2e98ff67a7.
  ATTACHMENT ID: 12694673

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new or modified
tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the total number
of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFiles

     {color:red}-1 core zombie tests{color}.  There are 1 zombie test(s): 	at org.apache.hadoop.hbase.TestAcidGuarantees.testScanAtomicity(TestAcidGuarantees.java:354)

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/12594//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12594//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12594//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12594//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12594//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12594//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12594//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12594//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12594//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12594//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12594//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12594//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/12594//artifact/patchprocess/checkstyle-aggregate.html

  Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12594//console

This message is automatically generated.

> Use acl cache for doing access control checks in prepare and clean phases of Bulkloading.
> -----------------------------------------------------------------------------------------
>
>                 Key: HBASE-12925
>                 URL: https://issues.apache.org/jira/browse/HBASE-12925
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Srikanth Srungarapu
>            Assignee: Srikanth Srungarapu
>         Attachments: HBASE-12925.patch, HBASE-12925_v2.patch
>
>
> Currently, prepareBulkLoad and cleanupBulkLoad are using "hasSomeAccess", which performs
scan on ACL table, instead of using TableAuthManager. Also, the method "hasSomeAccess" has
a logical error, as it doesn't filter the acl scan results by the current active user. More
specifically 
> {code}
> for (UserPermission userPerm: perms) {
>         for (Action userAction: userPerm.getActions()) {
>           if (userAction.equals(action)) {
>             return AuthResult.allow(method, "Access allowed", requestUser,
>               action, tableName, null, null);
>           }
>         }
>       }
> {code} 
> The if clause ideally should be having something like userPerm.getUser.equals(requestUser).
This issue will help us in getting rid of this problematic implementation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message