hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nick Dimiduk (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12899) HBase should prefix htrace configuration keys with "hbase.htrace" rather than just "hbase."
Date Wed, 21 Jan 2015 23:27:36 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14286533#comment-14286533
] 

Nick Dimiduk commented on HBASE-12899:
--------------------------------------

We've had HTrace support since at least 0.96.0 \[0\], so I think backward compatibility is
a concern here. No need for full shims, just a simple check of both the old config values
and the new, print a fat WARN when the old config is used. No need to keep the BC around for
ever, just through the 1.x releases. The patch as you have it is fine for master/2.x.

\[0\]: https://issues.apache.org/jira/issues/?jql=project%20%3D%20HBASE%20AND%20status%20%3D%20Resolved%20AND%20text%20~%20%22htrace%22

> HBase should prefix htrace configuration keys with "hbase.htrace" rather than just "hbase."
> -------------------------------------------------------------------------------------------
>
>                 Key: HBASE-12899
>                 URL: https://issues.apache.org/jira/browse/HBASE-12899
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 1.0.0
>            Reporter: Colin Patrick McCabe
>         Attachments: HBASE-12899.001.patch
>
>
> In Hadoop, we pass all configuration keys starting with "hadoop.htrace" to htrace.  So
"hadoop.htrace.sampler.fraction" gets passed to HTrace as sampler.fraction, and so forth.
> For consistency, it seems like HBase should prefix htrace configuration keys with "hbase.htrace"
rather than just "hbase."



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message