hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nick Dimiduk (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12896) checkstyle report diff tool
Date Wed, 21 Jan 2015 20:34:34 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14286211#comment-14286211
] 

Nick Dimiduk commented on HBASE-12896:
--------------------------------------

Could do. That would require iterating through both child nodes and looking for the changes.
This is less obvious because line numbers shift after patch is applied. This version tells
you where to look, not exactly what you broke.

> checkstyle report diff tool
> ---------------------------
>
>                 Key: HBASE-12896
>                 URL: https://issues.apache.org/jira/browse/HBASE-12896
>             Project: HBase
>          Issue Type: Improvement
>          Components: build
>            Reporter: Nick Dimiduk
>            Assignee: Nick Dimiduk
>            Priority: Minor
>         Attachments: HBASE-12896.00.patch
>
>
> The new check style stuff is great, but digging through all of our brokenness in the
report to track down what 3 things my patch broke is painful. So here's a script that does
the work for me.
> Maybe one of you Jenkins-aware folks can help me wire it into test-patch.sh so the output
gets posted all nice like in the buildbot output. Save me the trouble of running it by hand
all the time.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message