hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Purtell (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12878) Incorrect HFile path in TestHFilePerformance print output (fix for easier debugging)
Date Mon, 19 Jan 2015 17:56:35 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14282769#comment-14282769
] 

Andrew Purtell commented on HBASE-12878:
----------------------------------------

Flawless patch submission. 

Now is when a committer might have feedback. I see a small nit:
{code}
@@ -170,7 +170,7 @@ public class TestHFilePerformance extends AbstractHBaseTool {
     startTime();
 
     Path path = new Path(ROOT_DIR, fileType + ".Performance");
-    System.out.println(ROOT_DIR + path.getName());
+    System.out.println(ROOT_DIR + "/" + path.getName());
     FSDataOutputStream fout =  createFSOutput(path);
 
     if ("HFile".equals(fileType)){
{code}
Rather than use "/", we should use {{Path.SEPARATOR}}. However, this isn't consistently done
in the code base and this is a test utility so there's no need to make another patch. 

We might also ask you to provide backport patches for other branches if you are asking for
a change to a specific prior version, like 0.98. In this case the change is only one line
so that will also not be necessary. 

I will commit this to 0.98+ shortly, thanks for the patch [~vik.karma]

> Incorrect HFile path in TestHFilePerformance print output (fix for easier debugging)
> ------------------------------------------------------------------------------------
>
>                 Key: HBASE-12878
>                 URL: https://issues.apache.org/jira/browse/HBASE-12878
>             Project: HBase
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 2.0.0, 0.98.8
>            Reporter: Vikas Vishwakarma
>            Priority: Minor
>         Attachments: HBASE-12878.patch
>
>
> While trying to look at the issue in HBASE-12866, came across a minor issue in TestHFilePerformance
while printing the HFile path. This has a directory path delimiter missing. It is only a sysout
issue but can be fixed for easier debugging. So basically in timewrite function System.out.println(ROOT_DIR
+ path.getName());
> should be System.out.println(ROOT_DIR + "/" + path.getName());
> so that current output 
> ROOT_DIR/target/test-data/.../TestHFilePerformanceHFile.Performance
> is fixed as 
> ROOT_DIR/target/test-data/.../TestHFilePerformance/HFile.Performance



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message