hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12878) Incorrect HFile path in TestHFilePerformance print output (fix for easier debugging)
Date Mon, 19 Jan 2015 15:21:34 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14282595#comment-14282595
] 

Hadoop QA commented on HBASE-12878:
-----------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12693088/HBASE-12878.patch
  against master branch at commit 4d31779dd79ca814255e732747f1bcc373623f26.
  ATTACHMENT ID: 12693088

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new or modified
tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the total number
of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/12509//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12509//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12509//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12509//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12509//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12509//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12509//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12509//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12509//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12509//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12509//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12509//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/12509//artifact/patchprocess/checkstyle-aggregate.html

  Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12509//console

This message is automatically generated.

> Incorrect HFile path in TestHFilePerformance print output (fix for easier debugging)
> ------------------------------------------------------------------------------------
>
>                 Key: HBASE-12878
>                 URL: https://issues.apache.org/jira/browse/HBASE-12878
>             Project: HBase
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 2.0.0, 0.98.8
>            Reporter: Vikas Vishwakarma
>            Priority: Minor
>         Attachments: HBASE-12878.patch
>
>
> While trying to look at the issue in HBASE-12866, came across a minor issue in TestHFilePerformance
while printing the HFile path. This has a directory path delimiter missing. It is only a sysout
issue but can be fixed for easier debugging. So basically in timewrite function System.out.println(ROOT_DIR
+ path.getName());
> should be System.out.println(ROOT_DIR + "/" + path.getName());
> so that current output 
> ROOT_DIR/target/test-data/.../TestHFilePerformanceHFile.Performance
> is fixed as 
> ROOT_DIR/target/test-data/.../TestHFilePerformance/HFile.Performance



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message