hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Purtell (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12836) Tip of branch 0.98 has some binary incompatibilities with 0.98.0
Date Tue, 13 Jan 2015 23:27:35 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14276172#comment-14276172
] 

Andrew Purtell commented on HBASE-12836:
----------------------------------------

Minor nit:
{code}
@@ -69,9 +69,167 @@ public class CopyTable extends Configured implements Tool {
 
   private final static String JOB_NAME_CONF_KEY = "mapreduce.job.name";
 
+  static long deprecatedStartTime = 0;
+  static long deprecatedEndTime = 0;
+  static int deprecatedVersions = -1;
+  static String deprecatedTableName = null;
+  static String deprecatedStartRow = null;
+  static String deprecatedStopRow = null;
+  static String deprecatedNewTableName = null;
+  static String deprecatedPeerAddress = null;
+  static String deprecatedFamilies = null;
+  static boolean deprecatedAllCells = false;
{code}
Rather than name these deprecated$FOO, can these be annotated?

> Tip of branch 0.98 has some binary incompatibilities with 0.98.0
> ----------------------------------------------------------------
>
>                 Key: HBASE-12836
>                 URL: https://issues.apache.org/jira/browse/HBASE-12836
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.98.10
>            Reporter: Dima Spivak
>         Attachments: HBASE-12836.patch, HBASE-12836_copy_table.patch, HBASE-12836_v2.patch
>
>
> In working on HBASE-12808, I ran a scan between the 0.98.0 tag and the tip of branch
0.98 and found a handful of binary incompatibilities that are probably worth addressing:
> - org.apache.hadoop.hbase.security.access.AccessControlClient.grant and org.apache.hadoop.hbase.security.access.AccessControlClient.revoke
had their return types and parameter lists changed in HBASE-12161. cc: [~srikanth235] and
[~mbertozzi].
> - org.apache.hadoop.hbase.mapreduce.CopyTable.createSubmittableJob is no longer static
and its parameter list changed in HBASE-11997. cc: [~daviddengcn] and [~tedyu].
> - getBlockSize was added to the org.apache.hadoop.hbase.io.crypto.Encryptor interface
in HBASE-11446, which may lead to an AbstractMethodError exception in a 0.98.0 client that
doesn't have this implemented. I suspect this one is worth living with? cc: [~apurtell].



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message