hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12835) HBASE-12422 changed new HTable(Configuration) to not use managed Connections anymore
Date Mon, 12 Jan 2015 21:47:35 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14274223#comment-14274223
] 

Hadoop QA commented on HBASE-12835:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12691712/hbase-12835_v2.patch
  against master branch at commit 5b850caa801d033d800bf6c1bea32aa2c7bda273.
  ATTACHMENT ID: 12691712

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the total number
of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/12423//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12423//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12423//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12423//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12423//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12423//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12423//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12423//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12423//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12423//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12423//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12423//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/12423//artifact/patchprocess/checkstyle-aggregate.html

  Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12423//console

This message is automatically generated.

> HBASE-12422 changed new HTable(Configuration) to not use managed Connections anymore
> ------------------------------------------------------------------------------------
>
>                 Key: HBASE-12835
>                 URL: https://issues.apache.org/jira/browse/HBASE-12835
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Enis Soztutar
>            Assignee: Enis Soztutar
>             Fix For: 1.0.0, 1.1.0
>
>         Attachments: hbase-12835_v1.patch, hbase-12835_v2.patch, hbase-12835_v2.patch
>
>
> While debugging something else, I've noticed that HBASE-12422 changed it so that new
HTable(Configuration, TableName) is not using managed connections anymore. 
> I thought the plan was to keep new HTable(Conf, TableName) to still use managed connections,
but allow the new APIs to have un-managed connections. With HBASE-12422, there is a big compatibility
change for used of the HTable interface that suddenly they will be launching connections per
HTable instance which is a behavioral change and expensive (with all the meta cache, zk threads,
thread pool, etc). I fear that this will catch unsuspecting users by surprise, that is why
I think we should revert back to the deprecated behavior for 1.0. For master we do not need
to make the change, but document it. 
> [~sduskis], [~saint.ack@gmail.com], [~ndimiduk] what do you guys think?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message