hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anoop Sam John (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12831) Changing the set of vis labels a user has access to doesn't generate an audit log event
Date Tue, 13 Jan 2015 03:44:35 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14274654#comment-14274654
] 

Anoop Sam John commented on HBASE-12831:
----------------------------------------

{code}
List<String> labelsStr = new ArrayList<String>(visLabels.size());
...
labelsStr.add(Bytes.toString(label));
...
if (AUDITLOG.isTraceEnabled()) {
  AUDITLOG.trace("Add labels: " + labelsStr);
}
{code}
Have labels in a List<byte[]> Do the string conversion only within if block..   Similarly
other places too.
{code}
if (AUDITLOG.isTraceEnabled()) {
  // make labelsStr List convertion bytes to string
  AUDITLOG.trace("Add labels: " + labelsStr);
}
{code}

> Changing the set of vis labels a user has access to doesn't generate an audit log event
> ---------------------------------------------------------------------------------------
>
>                 Key: HBASE-12831
>                 URL: https://issues.apache.org/jira/browse/HBASE-12831
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 1.0.0, 2.0.0, 0.98.6
>            Reporter: Sean Busbey
>            Assignee: Ashish Singhi
>              Labels: audit
>             Fix For: 1.0.1, 0.98.11
>
>         Attachments: HBASE-12831.patch
>
>
> Right now, the AccessController makes sure that (when users care about audit events)
we generate an audit log event for any access change, like granting or removing a permission
from a user.
> When the set of labels a user has access to is altered, it gets handled by the VisibilityLabelService
and we don't log anything to the audit log.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message