hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matteo Bertozzi (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12819) ExportSnapshot doesn't close FileSystem instances
Date Wed, 07 Jan 2015 22:24:34 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14268392#comment-14268392
] 

Matteo Bertozzi commented on HBASE-12819:
-----------------------------------------

why the inputFs is not closed too?
also what about the inputFs and outputFs in the ExportMapper? implement the cleanup() method
and close them there?
(not sure if the FileSystem instances are ref-counted. if not there may be more work for the
mapper, to avoid that the mapper close() is thrashing the fs instances in the main when you
are in the single jvm case, e.g. tests)

> ExportSnapshot doesn't close FileSystem instances
> -------------------------------------------------
>
>                 Key: HBASE-12819
>                 URL: https://issues.apache.org/jira/browse/HBASE-12819
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>         Attachments: 12819-v1.patch
>
>
> While troubleshooting an out of memory error exporting snapshot to s3a, I found that
ExportSnapshot doesn't close FileSystem instances it uses.
> An implementation (s3a e.g.) may depend on close() call so that resources are released.
> ExportSnapshot should close the FileSystem instances upon exit.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message