hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12801) Failed to truncate a table while maintaing binary region boundaries
Date Sun, 04 Jan 2015 07:02:34 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14263774#comment-14263774
] 

Hadoop QA commented on HBASE-12801:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12689962/HBASE-12801-0.94-v1.diff
  against master branch at commit ac95cc1fbb951bb9db96f2738f621d1d7cd45739.
  ATTACHMENT ID: 12689962

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12296//console

This message is automatically generated.

> Failed to truncate a table while maintaing binary region boundaries
> -------------------------------------------------------------------
>
>                 Key: HBASE-12801
>                 URL: https://issues.apache.org/jira/browse/HBASE-12801
>             Project: HBase
>          Issue Type: Bug
>          Components: shell
>    Affects Versions: 0.94.11
>            Reporter: Liu Shaohui
>            Assignee: Liu Shaohui
>            Priority: Minor
>             Fix For: 2.0.0, 0.94.28
>
>         Attachments: HBASE-12801-0.94-v1.diff, HBASE-12801-trunk-v1.diff
>
>
> Binary region boundaries become wrong during 
> converting byte array to normal string, and back to byte array in truncate_preserve of
admin.rb, which makes the truncation of table failed.
> See: truncate_preserve method in admin.rb
> {code}
>  splits = h_table.getRegionLocations().keys().map{|i| Bytes.toString(i.getStartKey)}.delete_if{|k|
k == ""}.to_java :String
>  splits = org.apache.hadoop.hbase.util.Bytes.toByteArrays(splits)
> {code}
> eg:
> {code}
> \xFA\x00\x00\x00\x00\x00\x00\x00 ->  \xEF\xBF\xBD\x00\x00\x00\x00\x00\x00\x00
> \xFC\x00\x00\x00\x00\x00\x00\x00 -> \xEF\xBF\xBD\x00\x00\x00\x00\x00\x00\x00
> {code}
> Simple patch is using binary string instead of normal string.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message