hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Enis Soztutar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12787) Backport HBASE-12028 (Abort the RegionServer when it's handler threads die) to 0.98
Date Wed, 07 Jan 2015 19:09:36 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14268030#comment-14268030
] 

Enis Soztutar commented on HBASE-12787:
---------------------------------------

This looks good if the test works and Phoenix can compile with this except for two things:

 - Formatting. You should use 2 spaces for all patches. You can change your eclipse settings
for that for future. 
 - In 0.98 I think we should default to 0 for the setting , meaning this is disabled by default.
We can keep it enabled by default for 1.0 and master. 

> Backport HBASE-12028 (Abort the RegionServer when it's handler threads die) to 0.98
> -----------------------------------------------------------------------------------
>
>                 Key: HBASE-12787
>                 URL: https://issues.apache.org/jira/browse/HBASE-12787
>             Project: HBase
>          Issue Type: Task
>            Reporter: Andrew Purtell
>            Assignee: Alicia Ying Shu
>              Labels: phoenix
>             Fix For: 0.98.10
>
>         Attachments: hbase-12028-0.98.patch
>
>
> Backport HBASE-12028 (Abort the RegionServer when it's handler threads die) to 0.98.
There are two 0.98-specific changes that should be addressed:
> # The default configuration should preserve current behavior
> # The interface change to RpcSchedulerFactory should be binary compatible for Phoenix
if possible, and we can do this by detecting with reflection if an older implementation of
the interface is missing the new 'create' method and by invoking the older deprecated 'create'
method instead. We can cache the decision after making it once.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message