hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Purtell (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12729) Backport HBASE-5162 (Basic client pushback mechanism) to 0.98
Date Sat, 10 Jan 2015 03:12:34 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14272301#comment-14272301
] 

Andrew Purtell commented on HBASE-12729:
----------------------------------------

Hey [~jesse_yates], in the trunk patch, in RsRpcServices, this hunk:
{code}
@@ -1815,6 +1816,13 @@ public class RSRpcServices implements HBaseRPCErrorHandler,
             processed = checkAndRowMutate(region, regionAction.getActionList(),
                   cellScanner, row, family, qualifier, compareOp, comparator);
           } else {
+            ClientProtos.RegionLoadStats stats = mutateRows(region, regionAction.getActionList(),
+                cellScanner);
+            // add the stats to the request
+            if(stats != null) {
+              responseBuilder.addRegionActionResult(RegionActionResult.newBuilder()
+                  .addResultOrException(ResultOrException.newBuilder().setLoadStats(stats)));
+            }
             mutateRows(region, regionAction.getActionList(), cellScanner);
             processed = Boolean.TRUE;
           }
{code}
This is applying the mutations twice. I think you meant to remove the second invocation of
mutateRows() right?

> Backport HBASE-5162 (Basic client pushback mechanism) to 0.98
> -------------------------------------------------------------
>
>                 Key: HBASE-12729
>                 URL: https://issues.apache.org/jira/browse/HBASE-12729
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Client, regionserver
>            Reporter: Andrew Purtell
>            Assignee: Andrew Purtell
>             Fix For: 0.98.10
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message