hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12723) Update ACL matrix to reflect reality
Date Sat, 24 Jan 2015 01:26:35 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14290334#comment-14290334

Hadoop QA commented on HBASE-12723:

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  against master branch at commit 588b43b06ba9a3434dc2178b5b014283cc959d62.
  ATTACHMENT ID: 12694286

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

                {color:red}-1 checkstyle{color}.  The applied patch generated 1943 checkstyle
errors (more than the master's current 1938 errors).

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
    +                                     List<TableName> tableNamesList, List<HTableDescriptor>
+                                      List<TableName> tableNamesList, List<HTableDescriptor>
+                                List<HTableDescriptor> descriptors, String regex) throws
IOException {
+                              final String userName, final TableName tableName, final Quotas
quotas) throws IOException {
+                              final String userName, final String namespace, final Quotas
quotas) throws IOException {
+And for the operations marked with *, the checks are done in post hook and only subset of
results satisfying access checks are returned back to the user.::

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/12575//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12575//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12575//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12575//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12575//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12575//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12575//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12575//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12575//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12575//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12575//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12575//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/12575//artifact/patchprocess/checkstyle-aggregate.html

                Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12575//console

This message is automatically generated.

> Update ACL matrix to reflect reality
> ------------------------------------
>                 Key: HBASE-12723
>                 URL: https://issues.apache.org/jira/browse/HBASE-12723
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Enis Soztutar
>            Assignee: Srikanth Srungarapu
>             Fix For: 2.0.0, 1.0.1, 1.1.0
>         Attachments: HBASE-12723.patch, book.html
> The ACL matrix in the book should be updated with the recent changes.  
> https://hbase.apache.org/book/appendix_acl_matrix.html
> Also the format is not optimal. There is a hierarchy relation between scopes (GLOBAL
> NS > TABLE), but not so much between Permissions (A,C,R)
> Some things to do:
> - {{Minimum Permission}} column does not make sense. We should replace it. 
> - Add information about superuser 
> - grant is a multi level thing. Required permissions depend on the scope.
> - See HBASE-12511 and others changed some of the permissions 
> What I would like to see at the end is something like:
> {code}
> createNamespace        : superuser | global(A)
> deleteNamespace        : superuser | global(A) | NS(A)
> modifyNamespace        : superuser | global(A) | NS(A)
> getNamespaceDescriptor : superuser | global(A) | NS(A)
> listNamespaces         : All access*
> createTable            : superuser | global(C) | NS(C)
> grant 
>   NS Perm              : superuser | global(A) | NS(A)
>   Table Perm           : ...
> revoke 
>   NS Perm              : superuser | global(A) | NS(A)
>   Table Perm           : ...
> getPerms 
>   NS perm              : superuser | global(A) | NS(A)
>   Table Perm           : ...
> {code}
> See HBASE-12511. 

This message was sent by Atlassian JIRA

View raw message