hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Busbey (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11983) HRegion constructors should not create HLog
Date Tue, 13 Jan 2015 21:01:35 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14275934#comment-14275934

Sean Busbey commented on HBASE-11983:

Yeah, I've wanted that for awhile and it's probably a better use of time than trying to handle
bringing the number down in one fell swoop. filed HBASE-12850 against myself.

FWIW, I've done this manually before by looking at the check-patch util; it'll tell you which
file to save and then diff.

> HRegion constructors should not create HLog 
> --------------------------------------------
>                 Key: HBASE-11983
>                 URL: https://issues.apache.org/jira/browse/HBASE-11983
>             Project: HBase
>          Issue Type: Bug
>          Components: wal
>            Reporter: Enis Soztutar
>            Assignee: Nick Dimiduk
>              Labels: beginner
>             Fix For: 2.0.0, 1.1.0
>         Attachments: HBASE-11983.00.patch, HBASE-11983.01.patch, HBASE-11983.02.patch,
HBASE-11983.03.patch, HBASE-11983.03.patch, HBASE-11983.04.patch, HBASE-11983.05.patch
> We should get rid of HRegion creating its own HLog. It should ALWAYS get the log from
> I think this was added for unit tests, but we should refrain from such practice in the
future (adding UT constructors always leads to weird and critical bugs down the road). See
recent: HBASE-11982, HBASE-11654. 
> Get rid of weird things like ignoreHLog:
> {code}
>   /**
>    * @param ignoreHLog - true to skip generate new hlog if it is null, mostly for createTable
>    */
>   public static HRegion createHRegion(final HRegionInfo info, final Path rootDir,
>                                       final Configuration conf,
>                                       final HTableDescriptor hTableDescriptor,
>                                       final HLog hlog,
>                                       final boolean initialize, final boolean ignoreHLog)
> {code}
> We can unify all the createXX and newXX methods and separate creating a region in the
file system vs opening a region. 

This message was sent by Atlassian JIRA

View raw message