hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nick Dimiduk (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-11983) HRegion constructors should not create HLog
Date Thu, 08 Jan 2015 18:37:35 GMT

     [ https://issues.apache.org/jira/browse/HBASE-11983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Nick Dimiduk updated HBASE-11983:
---------------------------------
    Attachment: HBASE-11983.03.patch

Addressing comments from [~esteban] and [~enis] from RB. Thanks for the comments guys. I respectfully
disagree on two points, but everything else is addressed in this patch. Will spin through
HadoopQA. Meanwhile, let me know if you feel strongly about either point, I can pick those
back up.

> HRegion constructors should not create HLog 
> --------------------------------------------
>
>                 Key: HBASE-11983
>                 URL: https://issues.apache.org/jira/browse/HBASE-11983
>             Project: HBase
>          Issue Type: Bug
>          Components: wal
>            Reporter: Enis Soztutar
>            Assignee: Nick Dimiduk
>              Labels: beginner
>             Fix For: 2.0.0, 1.1.0
>
>         Attachments: HBASE-11983.00.patch, HBASE-11983.01.patch, HBASE-11983.02.patch,
HBASE-11983.03.patch
>
>
> We should get rid of HRegion creating its own HLog. It should ALWAYS get the log from
outside. 
> I think this was added for unit tests, but we should refrain from such practice in the
future (adding UT constructors always leads to weird and critical bugs down the road). See
recent: HBASE-11982, HBASE-11654. 
> Get rid of weird things like ignoreHLog:
> {code}
>   /**
>    * @param ignoreHLog - true to skip generate new hlog if it is null, mostly for createTable
>    */
>   public static HRegion createHRegion(final HRegionInfo info, final Path rootDir,
>                                       final Configuration conf,
>                                       final HTableDescriptor hTableDescriptor,
>                                       final HLog hlog,
>                                       final boolean initialize, final boolean ignoreHLog)
> {code}
> We can unify all the createXX and newXX methods and separate creating a region in the
file system vs opening a region. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message