hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dima Spivak (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11677) Make Logger instance modifiers consistent
Date Thu, 15 Jan 2015 18:45:36 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14279088#comment-14279088

Dima Spivak commented on HBASE-11677:

Can you clarify which solution you favor over just removing/commenting out the setLevel calls,
[~enis]? Back in HBASE-12285, we commented out some of these because they were leading to
an absurd amount of output, but I can revisit this if you think there's a better way to go.

For what it's worth, we should balance adequate logging for debugging (specifically, around
tests that fail at least sometimes), with the problem of overly verbose tests. We still have
the problem to some degree--the last successful build of master shows that hbase-server has
67 tests that output more than a megabyte and at least a couple printing 20+ MB during every
single run--but at least it's not causing build failures anymore.

> Make Logger instance modifiers consistent
> -----------------------------------------
>                 Key: HBASE-11677
>                 URL: https://issues.apache.org/jira/browse/HBASE-11677
>             Project: HBase
>          Issue Type: Task
>            Reporter: Sean Busbey
>            Priority: Minor
>              Labels: beginner, sonar
>         Attachments: HBASE-11677-v1.patch, HBASE-11677-v2.patch, HBASE-11677-v3.patch,
> We have some instances of Logger that are missing one of being private, static, and final.
> ex from HealthChecker.java, missing final
> {code}
>     private static Log LOG = LogFactory.getLog(HealthChecker.class);
> {code}
> * Clean up where possible by making {{private static final}}
> * If we can't, add a non-javadoc note about why
> One way to look for problematic instances is to grep for initial assignment for the commonly
used LOG member, e.g.
> * missing final: {{grep -r "LOG =" * | grep -v "final"}}
> * missing static: {{grep -r "LOG =" * | grep -v "static"}}
> * missing private: {{grep -r "LOG =" * | grep -v "private"}}

This message was sent by Atlassian JIRA

View raw message