hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Busbey (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11677) Make Logger instance modifiers consistent
Date Tue, 20 Jan 2015 21:07:35 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14284412#comment-14284412

Sean Busbey commented on HBASE-11677:

bq. Would that work? Now we will log a lot of stuff for every test, not just selected tests,

I'm not sure how much more logging we'll do. The other case never stepped the logging back
down, so we'd already be keeping the log level up whenever JVMs get reused. (But I don't know
how much we're reusing JVMs)

Before we take measurements, does anyone have an acceptable amount of additional logging in
mind? Or should we just find a way to alter the impacted log levels programmatically that
doesn't involve those members being visible?

> Make Logger instance modifiers consistent
> -----------------------------------------
>                 Key: HBASE-11677
>                 URL: https://issues.apache.org/jira/browse/HBASE-11677
>             Project: HBase
>          Issue Type: Task
>            Reporter: Sean Busbey
>            Priority: Minor
>              Labels: beginner, sonar
>         Attachments: HBASE-11677-v1.patch, HBASE-11677-v2.patch, HBASE-11677-v3.patch,
HBASE-11677-v4.patch, HBASE-11677.patch
> We have some instances of Logger that are missing one of being private, static, and final.
> ex from HealthChecker.java, missing final
> {code}
>     private static Log LOG = LogFactory.getLog(HealthChecker.class);
> {code}
> * Clean up where possible by making {{private static final}}
> * If we can't, add a non-javadoc note about why
> One way to look for problematic instances is to grep for initial assignment for the commonly
used LOG member, e.g.
> * missing final: {{grep -r "LOG =" * | grep -v "final"}}
> * missing static: {{grep -r "LOG =" * | grep -v "static"}}
> * missing private: {{grep -r "LOG =" * | grep -v "private"}}

This message was sent by Atlassian JIRA

View raw message