hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Lawlor (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-6778) Deprecate Chore; its a thread per task when we should have one thread to do all tasks
Date Wed, 28 Jan 2015 18:54:35 GMT

     [ https://issues.apache.org/jira/browse/HBASE-6778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jonathan Lawlor updated HBASE-6778:
-----------------------------------
    Attachment: HBASE_6778_v4.patch

new patch attached to fix:

bq. you removed delayed from ConnectionManager.java but you are still starting up a choreservice?
We need to?

Good catch, it is definitely not needed. Removed

bq. How does the choreservice in AuthUtils get shutdown? It never was shutdown it looks like?

AuthUtil now returns a scheduledChore rather than actually starting the chore in the static
function. The caller of the static method is responsible for starting that chore with a choreService
that they can manage

Added guards to logs and removed invisible ink javadoc

The change in MasterServices was caused by eclipse auto-formatter.

bq. In places like ConnectionCache.java, for sure the chore executor is being shut down?

Added a shutdown method and a call to it where it is used. Also, in ThreadPoolExecutors shutdown()
inside finalize so in the case where ChoreService#shutdown() is missed, the executor will
still shutdown gracefully during GC

Also, added timeouts to the tests that have been failing in the hope that the flaky tests
will succeed after a timeout. (*fingers crossed*)

> Deprecate Chore; its a thread per task when we should have one thread to do all tasks
> -------------------------------------------------------------------------------------
>
>                 Key: HBASE-6778
>                 URL: https://issues.apache.org/jira/browse/HBASE-6778
>             Project: HBase
>          Issue Type: Bug
>            Reporter: stack
>            Assignee: Jonathan Lawlor
>             Fix For: 2.0.0, 1.1.0
>
>         Attachments: AFTER_thread_dump.txt, BEFORE_thread_dump.txt, HBASE_6778_WIP_v1.patch,
HBASE_6778_WIP_v2.patch, HBASE_6778_v1.patch, HBASE_6778_v2.patch, HBASE_6778_v3.patch, HBASE_6778_v3.patch,
HBASE_6778_v4.patch, thread_dump_HMaster.local.out
>
>
> Should use something like ScheduledThreadPoolExecutor instead (Elliott said this first
I think; J-D said something similar just now).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message