hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Cosmin Lehene (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5532) get NPE during MajorCompactionChecker
Date Wed, 07 Jan 2015 13:18:34 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14267612#comment-14267612
] 

Cosmin Lehene commented on HBASE-5532:
--------------------------------------

[~terry_zhang], [~apurtell] this may not apply anymore. 
The code has changed a bit, and it seems we check for null readers. I'm not sure about the
locking semantics.

The logic has moved to StoreFile.java and there's related logic in StripeStoreFileManager

isMajorCompaction() is in HStore.java

> get NPE during MajorCompactionChecker 
> --------------------------------------
>
>                 Key: HBASE-5532
>                 URL: https://issues.apache.org/jira/browse/HBASE-5532
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>            Reporter: terry zhang
>              Labels: delete
>         Attachments: HBASE-5532-v2.patch, HBASE-5532.patch
>
>
> We found error log (NullPointerException) below on our online cluster:
> 2012-03-05 00:17:09,592 ERROR org.apache.hadoop.hbase.regionserver.HRegionServer$MajorCompactionChecker:
Caught exception
> java.lang.NullPointerException
>         at org.apache.hadoop.hbase.regionserver.Store.isMajorCompaction(Store.java:878)
>         at org.apache.hadoop.hbase.regionserver.Store.isMajorCompaction(Store.java:857)
>         at org.apache.hadoop.hbase.regionserver.HRegion.isMajorCompaction(HRegion.java:3017)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer$MajorCompactionChecker.chore(HRegionServer.java:1172)
>         at org.apache.hadoop.hbase.Chore.run(Chore.java:66)
> After Check the code we found although it already check whether store files has null
reader at the begin of the function(isMajorCompaction), but it still has some possibility
the reader is closed before it return(eg mini compaction). So we need to check store file
reader before we use it to avoid this NPE



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message