hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5205) Delete handles deleteFamily incorrectly
Date Tue, 06 Jan 2015 16:32:35 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14266346#comment-14266346

Hadoop QA commented on HBASE-5205:

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  against master branch at commit 26e3e1b300670d6c3f9f4853aa937226592b9537.
  ATTACHMENT ID: 12510658

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12332//console

This message is automatically generated.

> Delete handles deleteFamily incorrectly
> ---------------------------------------
>                 Key: HBASE-5205
>                 URL: https://issues.apache.org/jira/browse/HBASE-5205
>             Project: HBase
>          Issue Type: Bug
>          Components: Client
>            Reporter: Lars Hofhansl
>            Priority: Minor
>         Attachments: 5205.txt
> Delete.deleteFamily clears all other markers for the same family.
> That is not correct as some of these other markers might be for a later time.
> That logic should be removed.
> If (really) needed this can be slightly optimized by keeping track of the max TS so far
for each family.
> If both the TS-so-far and the TS of a new deleteFamily request is < LATEST_TIMESTAMP
and the TS-so-far is < deleteFamily marker, or if both the TS-so-far and the new TS equal
LATEST_TIMESTAMP, then the previous delete markerz for that family could be removed.
> I think that might be overkill, as most deletes issued from clients are for LATEST_TIMESTAMP
(which the server translates to the current time).
> I'll have a (one-line) patch soon. Unless folks insist on the optimization I mentioned

This message was sent by Atlassian JIRA

View raw message