Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Wed, 31 Dec 2014 18:54:13 +0000 (UTC)
From: "Jean-Daniel Cryans (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12764090.1419895252000.122733.1420052053588@Atlassian.JIRA>
In-Reply-To: <JIRA.12764090.1419895252000@Atlassian.JIRA>
References: <JIRA.12764090.1419895252000@Atlassian.JIRA>
 <JIRA.12764090.1419895252413@arcas>
Subject: [jira] [Commented] (HBASE-12774) Fix the inconsistent permission
 checks for bulkloading.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-12774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14262361#comment-14262361 ] 

Jean-Daniel Cryans commented on HBASE-12774:
--------------------------------------------

Can you fixup the javadoc that I missed in HBASE-11008 while you're there?

https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java#L1961

Also, I'd like [~apurtell]'s benediction on this.

> Fix the inconsistent permission checks for bulkloading.
> -------------------------------------------------------
>
>                 Key: HBASE-12774
>                 URL: https://issues.apache.org/jira/browse/HBASE-12774
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Srikanth Srungarapu
>            Assignee: Srikanth Srungarapu
>            Priority: Minor
>         Attachments: HBASE-12774.patch, HBASE-12774_v2.patch
>
>
> Three checks(prePrepareBulkLoad, preCleanupBulkLoad, preBulkLoadHFile)  are being done while performing secure bulk load, and it looks the former two checks for 'W', while the later checks for 'C'. After having offline chat with [~jdcryans], looks like the inconsistency among checks were unintended. So, we can address this multiple ways.
> * All checks should be for 'W'
> * All checks should be for 'C'
> * All checks should be for both 'W' and 'C'
> Posting the initial patch going by the first option. Open to discussion.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)