Return-Path: 
 <issues-return-174743-apmail-hbase-issues-archive=hbase.apache.org@hbase.apache.org>
X-Original-To: apmail-hbase-issues-archive@www.apache.org
Delivered-To: apmail-hbase-issues-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 97991100A6
	for <apmail-hbase-issues-archive@www.apache.org>;
 Sun, 14 Dec 2014 06:08:13 +0000 (UTC)
Received: (qmail 97800 invoked by uid 500); 14 Dec 2014 06:08:13 -0000
Delivered-To: apmail-hbase-issues-archive@hbase.apache.org
Received: (qmail 97719 invoked by uid 500); 14 Dec 2014 06:08:13 -0000
Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@hbase.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@hbase.apache.org>
List-Post: <mailto:issues@hbase.apache.org>
List-Id: <issues.hbase.apache.org>
Delivered-To: mailing list issues@hbase.apache.org
Received: (qmail 97421 invoked by uid 99); 14 Dec 2014 06:08:13 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 14 Dec 2014 06:08:13 +0000
Date: Sun, 14 Dec 2014 06:08:13 +0000 (UTC)
From: "Jerry He (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12761599.1418537208000.18659.1418537293217@Atlassian.JIRA>
In-Reply-To: <JIRA.12761599.1418537208000@Atlassian.JIRA>
References: <JIRA.12761599.1418537208000@Atlassian.JIRA>
 <JIRA.12761599.1418537208332@arcas>
Subject: [jira] [Updated] (HBASE-12682) compaction thread throttle value is
 not correct in hbase-default.xml
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


     [ https://issues.apache.org/jira/browse/HBASE-12682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jerry He updated HBASE-12682:
-----------------------------
    Description: 
While doing some compaction tuning and looking up some of the parameters, I noticed that hbase.regionserver.thread.compaction.throttle default value in the documentation and in hbase-site.xml seems to be off the mark.

{code}
  <property>
    <name>hbase.regionserver.thread.compaction.throttle</name>
    <value>2560</value>
    <description>There are two different thread pools for compactions, one for large compactions and
      the other for small compactions. This helps to keep compaction of lean tables (such as
        <systemitem>hbase:meta</systemitem>) fast. If a compaction is larger than this threshold, it
      goes into the large compaction pool. In most cases, the default value is appropriate. Default:
      2 x hbase.hstore.compaction.max x hbase.hregion.memstore.flush.size (which defaults to 128).
      The value field assumes that the value of hbase.hregion.memstore.flush.size is unchanged from
      the default.</description>
  </property>
{code}

It should be in bytes. Or am I missing anything?
It is not a problem in 0.98 since the property is not in hbase-site.xml over there. It is obtained dynamically:
{code}
throttlePoint =  conf.getLong("hbase.regionserver.thread.compaction.throttle",
          2 * maxFilesToCompact * storeConfigInfo.getMemstoreFlushSize());
{code}


  was:
While doing some compaction tuning and looking up some of the parameters, I noticed that hbase.regionserver.thread.compaction.throttle default value in the documentation and in hbase-site.xml seems to be off the mark.

{code}
  <property>
    <name>hbase.regionserver.thread.compaction.throttle</name>
    <value>2560</value>
    <description>There are two different thread pools for compactions, one for large compactions and
      the other for small compactions. This helps to keep compaction of lean tables (such as
        <systemitem>hbase:meta</systemitem>) fast. If a compaction is larger than this threshold, it
      goes into the large compaction pool. In most cases, the default value is appropriate. Default:
      2 x hbase.hstore.compaction.max x hbase.hregion.memstore.flush.size (which defaults to 128).
      The value field assumes that the value of hbase.hregion.memstore.flush.size is unchanged from
      the default.</description>
  </property>
{code}

It should be in bytes. Or am I missing anyting?
It is not a problem in 0.98 since the property is not in hbase-site.xml over there. It is obtained dynamically:
{code}
throttlePoint =  conf.getLong("hbase.regionserver.thread.compaction.throttle",
          2 * maxFilesToCompact * storeConfigInfo.getMemstoreFlushSize());
{code}



> compaction thread throttle value is not correct in hbase-default.xml
> --------------------------------------------------------------------
>
>                 Key: HBASE-12682
>                 URL: https://issues.apache.org/jira/browse/HBASE-12682
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 2.0.0
>            Reporter: Jerry He
>            Assignee: Jerry He
>             Fix For: 2.0.0
>
>
> While doing some compaction tuning and looking up some of the parameters, I noticed that hbase.regionserver.thread.compaction.throttle default value in the documentation and in hbase-site.xml seems to be off the mark.
> {code}
>   <property>
>     <name>hbase.regionserver.thread.compaction.throttle</name>
>     <value>2560</value>
>     <description>There are two different thread pools for compactions, one for large compactions and
>       the other for small compactions. This helps to keep compaction of lean tables (such as
>         <systemitem>hbase:meta</systemitem>) fast. If a compaction is larger than this threshold, it
>       goes into the large compaction pool. In most cases, the default value is appropriate. Default:
>       2 x hbase.hstore.compaction.max x hbase.hregion.memstore.flush.size (which defaults to 128).
>       The value field assumes that the value of hbase.hregion.memstore.flush.size is unchanged from
>       the default.</description>
>   </property>
> {code}
> It should be in bytes. Or am I missing anything?
> It is not a problem in 0.98 since the property is not in hbase-site.xml over there. It is obtained dynamically:
> {code}
> throttlePoint =  conf.getLong("hbase.regionserver.thread.compaction.throttle",
>           2 * maxFilesToCompact * storeConfigInfo.getMemstoreFlushSize());
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)