hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12783) Create efficient RegionLocator implementation
Date Wed, 31 Dec 2014 05:30:13 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14261944#comment-14261944
] 

Hadoop QA commented on HBASE-12783:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12689631/HBASE-12873D.patch
  against master branch at commit 8514e2b20e4d9b4c4f1985392d6e93381ab37cc7.
  ATTACHMENT ID: 12689631

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 21 new or modified
tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 2 warning messages.

                {color:red}-1 checkstyle{color}.  The applied patch generated 2083 checkstyle
errors (more than the master's current 2076 errors).

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
100:
    +  public HRegionLocator(TableName tableName, ClusterConnection connection, Configuration
configuration) {
+      HFileOutputFormat2.configureIncrementalLoad(job, table.getTableDescriptor(), regionLocator,
HFileOutputFormat2.class);
+    HFileOutputFormat2.configureIncrementalLoad(job, table.getTableDescriptor(), table.getRegionLocator(),
HFileOutputFormat2.class);
+    configureIncrementalLoad(job, table.getTableDescriptor(), table.getRegionLocator(), HFileOutputFormat2.class);
+    configureIncrementalLoad(job, table.getTableDescriptor(), regionLocator, HFileOutputFormat2.class);
+        HFileOutputFormat2.configureIncrementalLoad(job, table.getTableDescriptor(), regionLocator,
HFileOutputFormat2.class);
+              HFileOutputFormat2.configureIncrementalLoad(job, table.getTableDescriptor(),
regionLocator, HFileOutputFormat2.class);
+        HFileOutputFormat2.configureIncrementalLoad(job, table.getTableDescriptor(), regionLocator,
HFileOutputFormat2.class);
+            arr[i] = new HRegionLocation(RegionReplicaUtil.getRegionInfoForReplica(region,
i), null);
+        try (HRegionLocator locator = spy((HRegionLocator) c.getRegionLocator(htd.getTableName())))
{

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFilesSplitRecovery
                  org.apache.hadoop.hbase.mapreduce.TestMultiTableInputFormat
                  org.apache.hadoop.hbase.mapreduce.TestSecureLoadIncrementalHFilesSplitRecovery
                  org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat

     {color:red}-1 core zombie tests{color}.  There are 3 zombie test(s): 	at org.apache.hadoop.hbase.client.TestFromClientSide.testScan_NullQualifier(TestFromClientSide.java:5329)
	at org.apache.hadoop.hbase.client.TestFromClientSide.testScan_NullQualifier(TestFromClientSide.java:5329)
	at org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat2.testMRIncrementalLoadWithSplit(TestHFileOutputFormat2.java:370)

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/12274//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12274//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12274//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12274//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12274//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12274//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12274//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12274//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12274//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12274//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12274//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12274//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/12274//artifact/patchprocess/checkstyle-aggregate.html

                Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12274//artifact/patchprocess/patchJavadocWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12274//console

This message is automatically generated.

> Create efficient RegionLocator implementation
> ---------------------------------------------
>
>                 Key: HBASE-12783
>                 URL: https://issues.apache.org/jira/browse/HBASE-12783
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 1.0.0, 2.0.0
>            Reporter: Solomon Duskis
>            Assignee: Solomon Duskis
>         Attachments: HBASE-12783.patch, HBASE-12873B.patch, HBASE-12873C.patch, HBASE-12873D.patch
>
>
> A new HRegionLocator that only implements RegionLocator functionality will be more efficient
to instantiate than a full HTable. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message