hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12752) Move from HServerAddress (0.89-fb) to ServerName in hbase-consensus module
Date Wed, 24 Dec 2014 03:44:13 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14257921#comment-14257921
] 

stack commented on HBASE-12752:
-------------------------------

In a quorum, machines are known by host and port  only; there is no consideration of startcode.
 Thats ok?  As far as a quorum client is concerned, as long as same host and port, it will
host same regions? (maybe that is the case currently and thats fine but later, we might want
to revisit?)

Is the compare in AbstractPeerManager (and in QuorumInfo ) going to be ok? (Where we compare
ServerName?)  We sure it is always going to be NON_STARTCODE?  If so, fine.  Might want to
add a comment to that effect on commit.

Move to ServerName is going to better if though it not exactly the right fit since HServerAddress
was doing DNS lookups under the floorboards.

Might want to change name of this method:

	  public ServerName getServerAddress() {

and ditto

 public static ServerName getHRegionServerAddress(

+1 Let me know if you need someone to commit to the branch for you.

> Move from HServerAddress (0.89-fb) to ServerName in hbase-consensus module
> --------------------------------------------------------------------------
>
>                 Key: HBASE-12752
>                 URL: https://issues.apache.org/jira/browse/HBASE-12752
>             Project: HBase
>          Issue Type: Sub-task
>          Components: hbase
>    Affects Versions: HBASE-12259
>            Reporter: Rishit Shroff
>            Assignee: Rishit Shroff
>            Priority: Minor
>             Fix For: HBASE-12259
>
>         Attachments: 0001-HBASE-12752-Get-rid-of-HServerAddress-from-hbase-con.patch
>
>
> 0.89-fb uses HServerAddress and so does hbase-consensus. The trunk has moved to ServerName
and we need to migrate from HServerAddress to ServerName.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message