hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12752) Move from HServerAddress (0.89-fb) to HostAndPort in hbase-consensus module
Date Sun, 28 Dec 2014 05:23:13 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14259574#comment-14259574
] 

stack commented on HBASE-12752:
-------------------------------

Patch looks good.

In below, you are worried the string may not be correctly formatted? Is that why you go from
string and back to string again?

	179	            HostAndPort leaderAddr = HostAndPort.fromString(leaderAddrString);
180	            leader = agentMap.get(leaderAddr.toString());

You do sam ein QuorumThriftClientAgent

QuorumThriftClientCLI and AbstractPeerManager add imports that are not used?

+1 on patch. Above nits can be addressed on commit.

> Move from HServerAddress (0.89-fb) to HostAndPort in hbase-consensus module
> ---------------------------------------------------------------------------
>
>                 Key: HBASE-12752
>                 URL: https://issues.apache.org/jira/browse/HBASE-12752
>             Project: HBase
>          Issue Type: Sub-task
>          Components: hbase
>    Affects Versions: HBASE-12259
>            Reporter: Rishit Shroff
>            Assignee: Rishit Shroff
>            Priority: Minor
>             Fix For: HBASE-12259
>
>         Attachments: 0001-Replace-HServerAddress-with-HostAndPort.patch
>
>
> 0.89-fb uses HServerAddress and so does hbase-consensus. The trunk has moved to ServerName
and we need to migrate from HServerAddress to ServerName.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message