hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Hsieh (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-12749) Tighten HFileLink api to enable non-snapshot uses
Date Wed, 24 Dec 2014 03:35:13 GMT

     [ https://issues.apache.org/jira/browse/HBASE-12749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jonathan Hsieh updated HBASE-12749:
-----------------------------------
    Attachment: hbase-12749.v4.patch

I think checkstyle and javac warnings are fighting each other.

In this case I prefer the no empty ';' version.

{code}
jon@swoop:~/proj/hbase-trunk$ diff hbase-12749.v3.patch hbase-12749.v4.patch 
2c2
< index 4c1f8c5..5b9c743 100644
---
> index 4c1f8c5..7d96920 100644
34,51d33
< @@ -299,7 +301,7 @@ public class FileLink {
<            currentPath = path;
<            return(in);
<          } catch (FileNotFoundException e) {
< -          // Try another file location
< +          ; // Try another file location
<          }
<        }
<        throw new FileNotFoundException("Unable to open link: " + fileLink);
< @@ -381,7 +383,7 @@ public class FileLink {
<        try {
<          return fs.getFileStatus(locations[i]);
<        } catch (FileNotFoundException e) {
< -        // Try another file location
< +        ; // Try another file location
<        }
<      }
<      throw new FileNotFoundException("Unable to open link: " + this);
{code}

> Tighten HFileLink api to enable non-snapshot uses
> -------------------------------------------------
>
>                 Key: HBASE-12749
>                 URL: https://issues.apache.org/jira/browse/HBASE-12749
>             Project: HBase
>          Issue Type: Bug
>          Components: snapshots
>    Affects Versions: 2.0.0, 1.1.0
>            Reporter: Jonathan Hsieh
>            Assignee: Jonathan Hsieh
>         Attachments: hbase-12749.patch, hbase-12749.v2.patch, hbase-12749.v3.patch, hbase-12749.v4.patch
>
>
> In HBASE-12332 we'd like to use the FileLink's IO redirecting powers but want to be able
to specify arbitrary alternate link paths and not be tied to the SnapshotFileLink file pattern
(aka, table=region-hfile).  
> To do this we need change the constructors and some internals so that it is more generic.
 Along the way, we remove the FileStatus constructor arguments in favor of Path's and reduce
the number of ways to create HFileLinks, and tighten up the scope privacy of many methods.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message