hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jurriaan Mous (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-12740) Improve performance of TestHBaseFsck
Date Tue, 23 Dec 2014 12:49:13 GMT

     [ https://issues.apache.org/jira/browse/HBASE-12740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jurriaan Mous updated HBASE-12740:
----------------------------------
    Attachment: HBASE-12740-v1.patch

- Added a close to HBaseFsck so it cleans up its internal connection, meta table and admin.
This lowered the open threads in a big way! I also added this close to more tests which uses
HBaseFsck and HBaseFsck created by HbckTestingUtil now auto closes. (It only closed the resources
when run through exec method and never in tests.)
- Removed more deprecated calls. 

Reaction to [~dimaspivak]:
- setupTableWithRegionReplica now returns void 
- changed deleteTable to cleanupTable and let it use deleteTable in HBaseTestingUtility.
- the 7 thread count is now a variable.

> Improve performance of TestHBaseFsck
> ------------------------------------
>
>                 Key: HBASE-12740
>                 URL: https://issues.apache.org/jira/browse/HBASE-12740
>             Project: HBase
>          Issue Type: Bug
>          Components: util
>            Reporter: Jurriaan Mous
>            Assignee: Jurriaan Mous
>         Attachments: HBASE-12740-v1.patch, HBASE-12740.patch
>
>
> TestHBaseFsck performs poor on my machine. It crashes because the threads reach the 2000
thread limit on my machine. Looking at the code a lot of optimization is possible and some
API calls are used wrong. A lot of Admin instances are created and never closed, lots of Tables
are not closed, ThreadPoolExecutors are not shut down and an unlimited thread pool which does
not recycle threads.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message