hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12740) Improve performance of TestHBaseFsck
Date Tue, 30 Dec 2014 22:31:14 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14261570#comment-14261570
] 

Hudson commented on HBASE-12740:
--------------------------------

SUCCESS: Integrated in HBase-TRUNK #5979 (See [https://builds.apache.org/job/HBase-TRUNK/5979/])
Revert "HBASE-12740 Improve performance of TestHBaseFsck" (stack: rev 734324e80f44be4d40b1ee4612a838b581d504b2)
* hbase-server/src/test/java/org/apache/hadoop/hbase/util/hbck/TestOfflineMetaRebuildHole.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/util/hbck/HbckTestingUtil.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsckRepair.java


> Improve performance of TestHBaseFsck
> ------------------------------------
>
>                 Key: HBASE-12740
>                 URL: https://issues.apache.org/jira/browse/HBASE-12740
>             Project: HBase
>          Issue Type: Bug
>          Components: util
>            Reporter: Jurriaan Mous
>            Assignee: Jurriaan Mous
>         Attachments: HBASE-12740-v1.patch, HBASE-12740-v2.patch, HBASE-12740-v3.patch,
HBASE-12740-v4.patch, HBASE-12740-v4.patch, HBASE-12740.patch, PROFILE_after_patch.png, PROFILE_before_patch_test_fails.png
>
>
> TestHBaseFsck performs poor on my machine. It crashes because the threads reach the 2000
thread limit on my machine. Looking at the code a lot of optimization is possible and some
API calls are used wrong. A lot of Admin instances are created and never closed, lots of Tables
are not closed, ThreadPoolExecutors are not shut down and an unlimited thread pool which does
not recycle threads.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message