hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12736) Let MetaScanner recycle a given Connection
Date Tue, 23 Dec 2014 00:03:13 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14256338#comment-14256338
] 

stack commented on HBASE-12736:
-------------------------------

Looking at your graphs, you are using 20% less threads AFTER your patch goes in; it just looks
like more are sticking around when test is done (less GC too but yeah, more heap -- maybe
the threads sticking around are holding on to references?)  Can you see what threads are sticking
around AFTER the patch compared to BEFORE patch?

TestEndToEndSplitTransaction opens Connections that are not being closed? RegionChecker?

Otherwise patch looks good to me. Moves MetaScanner to more often take a Connection rather
than create one internally.  I'd be up for committing it.







> Let MetaScanner recycle a given Connection
> ------------------------------------------
>
>                 Key: HBASE-12736
>                 URL: https://issues.apache.org/jira/browse/HBASE-12736
>             Project: HBase
>          Issue Type: Improvement
>          Components: Client
>            Reporter: Jurriaan Mous
>            Assignee: Jurriaan Mous
>         Attachments: HBASE-12736-v1.patch, HBASE-12736-v2.patch, HBASE-12736-v3.patch,
HBASE-12736.patch, profile_TestMetaScanner_after_patch.png, profile_TestMetaScanner_before_patch.png
>
>
> It is very heavy to create a Connection on each meta scan. Connections create RpcClients,
RpcClients create RPC connections and all cannot be recycled.
> Tests with a lot of metascans are very heavy with the async client.
> This issue is to make anything that uses metaScans reuse the same connection.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message