hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12736) Let MetaScanner recycle a given Connection
Date Sat, 20 Dec 2014 19:15:13 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14254924#comment-14254924
] 

stack commented on HBASE-12736:
-------------------------------

You don't need to pass a configuration if you are passing a Connection in below?

  public static void metaScan(Configuration configuration, Connection connection,
74	      MetaScannerVisitor visitor) throws IOException {

.. but if it makes the patch smaller, just leave it as is.

We don't do this in codebase: import org.apache.hadoop.hbase.client.*;

We explicitly import needed classes.

Are all Connections and Tables being closed?

On the failing test, if you can't figure it, you can punt to me and I'll dig since it is probably
testing arcania, stuff I've had my head in this last few weeks.

Nice patch

> Let MetaScanner recycle a given Connection
> ------------------------------------------
>
>                 Key: HBASE-12736
>                 URL: https://issues.apache.org/jira/browse/HBASE-12736
>             Project: HBase
>          Issue Type: Improvement
>          Components: Client
>            Reporter: Jurriaan Mous
>            Assignee: Jurriaan Mous
>         Attachments: HBASE-12736-v1.patch, HBASE-12736.patch
>
>
> It is very heavy to create a Connection on each meta scan. Connections create RpcClients,
RpcClients create RPC connections and all cannot be recycled.
> Tests with a lot of metascans are very heavy with the async client.
> This issue is to make anything that uses metaScans reuse the same connection.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message