hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Hsieh (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12718) Convert TestAcidGuarantees from a unit test to an integration test
Date Fri, 19 Dec 2014 18:47:14 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14253771#comment-14253771
] 

Jonathan Hsieh commented on HBASE-12718:
----------------------------------------

I considered it but lean towards only having it in IT.

1) The main functionality this move buys us is the ability to use ChaosMonkey while the test
runs (since we derive off of IntegrationTestBase). To have it in both, I'd need to do some
refactoring.  
2) The test is non deterministic as a unit test and does the whole spin up a minicluster while
only using the public client apis.  if it fails it points out there a problem but doesn't
necessarily tell us where.  Unit tests ideally tell us where.
3) It isn't like the test has gone away -- it still can be executed against a minicluster
using mvn: 
{code}
mvn install -DskipTests
cd hbase-it
mvn verify -Dit.test=IntegrationTestAcidGuarantees
{code}

If those reasons are too weak, file an issue to refactor this and assign it to me.

> Convert TestAcidGuarantees from a unit test to an integration test
> ------------------------------------------------------------------
>
>                 Key: HBASE-12718
>                 URL: https://issues.apache.org/jira/browse/HBASE-12718
>             Project: HBase
>          Issue Type: Bug
>          Components: hbase, integration tests, test
>    Affects Versions: 1.0.0, 2.0.0
>            Reporter: Jonathan Hsieh
>            Assignee: Jonathan Hsieh
>             Fix For: 2.0.0, hbase-11339, 1.1.0
>
>         Attachments: hbase-12718.patch
>
>
> TestAcidGurantees has a main method so that it can be executed via the commandline. 
In the past this was run and we'd use external tools to inject faults while it executed for
an extended period of time.  We've had the IT framework we'd like to use the ChaosMonkey automation
with it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message