hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "zhangduo (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12715) Should pass regionName to HRegionServer.getLastSequenceId instead of encodedRegionName
Date Fri, 19 Dec 2014 00:32:13 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14252642#comment-14252642
] 

zhangduo commented on HBASE-12715:
----------------------------------

{quote}
Generally, encoded region name – because it is short – should be used especially if a
human does not have to read it.
{quote}
[~stack] ServerLoad is widely used and there is a reference in table_jsp.java, so I think
we should not change it to encodedRegionName since this is displayed to user?

> Should pass regionName to HRegionServer.getLastSequenceId instead of encodedRegionName
> --------------------------------------------------------------------------------------
>
>                 Key: HBASE-12715
>                 URL: https://issues.apache.org/jira/browse/HBASE-12715
>             Project: HBase
>          Issue Type: Bug
>          Components: wal
>    Affects Versions: 0.98.9
>            Reporter: zhangduo
>
> When addressing HBASE-12405 I found that LastSequenceId.getLastSequenceId(it is renamed
in master branch, doesn't matter) always returns -1, then I found that we use encodedRegionName
when calling this method. But when we doing regionServerReport, we use regionName to report
to HMaster(see the code in HRegionServer.createRegionLoad). 
> We need to fix this, as seems we will disable distributed log replay in 0.98 by default?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message