hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12684) Add new AsyncRpcClient
Date Sat, 20 Dec 2014 19:02:13 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14254921#comment-14254921
] 

stack commented on HBASE-12684:
-------------------------------

I don't see need of a return either. Regards EnvironmentEdgeManager, its sporadically applied
and mostly makes sense serverside, not so much clientside.  I suppose it could be used doing
timings in client but that is TODO. Let me leave comment over on rb.

Javadoc warnings are a bit hard to interpret.  See https://builds.apache.org/job/PreCommit-HBASE-Build/12172//artifact/patchprocess/patchJavadocWarnings.txt
 Look for WARNINGs.  Ones that complain about Unsafe or empty statements don't 'count'.  If
you keep searching, you'll find this:

1 warning
[WARNING] Javadoc Warnings
[WARNING] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java:544:
warning - @param argument "perm" is not a parameter name.

bq. Rolled back BlockingRpcChannelImplementation since it was needed for failing connections
to reconnect to a new RpcChannel. So could not be in Channel itself...

Can you say more about this for layman....




> Add new AsyncRpcClient
> ----------------------
>
>                 Key: HBASE-12684
>                 URL: https://issues.apache.org/jira/browse/HBASE-12684
>             Project: HBase
>          Issue Type: Improvement
>          Components: Client
>            Reporter: Jurriaan Mous
>            Assignee: Jurriaan Mous
>         Attachments: HBASE-12684-v1.patch, HBASE-12684-v2.patch, HBASE-12684-v3.patch,
HBASE-12684-v4.patch, HBASE-12684-v5.patch, HBASE-12684-v6.patch, HBASE-12684-v7.patch, HBASE-12684-v8.patch,
HBASE-12684.patch
>
>
> With the changes in HBASE-12597 it is possible to add new RpcClients. This issue is about
adding a new Async RpcClient which would enable HBase to do non blocking protobuf service
communication.
> Besides delivering a new AsyncRpcClient I would also like to ask the question what it
would take to replace the current RpcClient? This would enable to simplify async code in some
next issues.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message