hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12684) Add new AsyncRpcClient
Date Fri, 19 Dec 2014 23:45:30 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14254274#comment-14254274
] 

Ted Yu commented on HBASE-12684:
--------------------------------

{code}
+            createPreamble(b, authMethod);
+            f.channel().writeAndFlush(b).addListener(new ChannelFutureListener() {
+              @Override public void operationComplete(ChannelFuture future) throws Exception
{
+                if (!future.isSuccess()) {
+                  close(future.cause());
+                }
+              }
+            });
{code}
Should there be a return statement following the close() call ?
minor:
{code}
+      long callTime = System.currentTimeMillis() - startTime;
{code}
Please use EnvironmentEdgeManager#currentTime()

> Add new AsyncRpcClient
> ----------------------
>
>                 Key: HBASE-12684
>                 URL: https://issues.apache.org/jira/browse/HBASE-12684
>             Project: HBase
>          Issue Type: Improvement
>          Components: Client
>            Reporter: Jurriaan Mous
>            Assignee: Jurriaan Mous
>         Attachments: HBASE-12684-v1.patch, HBASE-12684-v2.patch, HBASE-12684-v3.patch,
HBASE-12684-v4.patch, HBASE-12684-v5.patch, HBASE-12684-v6.patch, HBASE-12684.patch
>
>
> With the changes in HBASE-12597 it is possible to add new RpcClients. This issue is about
adding a new Async RpcClient which would enable HBase to do non blocking protobuf service
communication.
> Besides delivering a new AsyncRpcClient I would also like to ask the question what it
would take to replace the current RpcClient? This would enable to simplify async code in some
next issues.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message